Brewing status - Merged - Printable Version +- Cuberite Forum (https://forum.cuberite.org) +-- Forum: Cuberite (https://forum.cuberite.org/forum-4.html) +--- Forum: Development (https://forum.cuberite.org/forum-13.html) +--- Thread: Brewing status - Merged (/thread-1983.html) |
RE: Brewing status - Seadragon91 - 06-17-2015 Okay, the exported methods for the api works fine If someone wants and has time, look at my brewing code and comment it for improvements / fixes or looking at the missing features with progress-bar and the click handle problem in SlotArea.cpp. RE: Brewing status - Seadragon91 - 06-17-2015 Have squashed all commits into one commit for easier review. Edit: Should I make a pull request for better commenting on github? RE: Brewing status - xoft - 06-17-2015 Definitely do. RE: Brewing status - Seadragon91 - 06-18-2015 Progress bars are now working fine RE: Brewing status - Seadragon91 - 06-30-2015 I was able to fix the slot handling problem. The brewing recipes needs a whole rework, is more trickier then I had thought and the list would be very big... RE: Brewing status - Review needed - Seadragon91 - 09-26-2015 Have recreated a pull request for it. Let's review and discuss it. RE: Brewing status - Review needed - Seadragon91 - 10-12-2015 Added hooks
I am not sure, if I should add a array in Brewinstand.h, that contains the result items for the bottle slots. This can be accessed from lua. RE: Brewing status - Review needed - Jammet - 10-16-2015 I'm going to test this stuff a lot once it's merged into the main branch . RE: Brewing status - Review needed - Seadragon91 - 10-16-2015 (10-16-2015, 09:24 PM)Jammet Wrote: I'm going to test this stuff a lot once it's merged into the main branch . I could compile a current windows cuberite version with the brewing included for you, if you want. RE: Brewing status - Review needed - Jammet - 10-18-2015 That's nice, but I'm running this on arm architecture. I'm cool with waiting, and once it's there, like, for everybody, gonna do a lot of brewin' . |