Cuberite Forum
Random Chitchat 2012-2016 - Printable Version

+- Cuberite Forum (https://forum.cuberite.org)
+-- Forum: Off Topic (https://forum.cuberite.org/forum-9.html)
+--- Forum: Off Topic Discussion (https://forum.cuberite.org/forum-10.html)
+--- Thread: Random Chitchat 2012-2016 (/thread-434.html)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487

RE: What we're doing - daniel0916 - 07-12-2014

And how can i do it then?

RE: What we're doing - FakeTruth - 07-13-2014

Fix this line
Code:
int UncompressedMaxSize = DataLength - (DataLength << 12) - (DataLength << 14) - (DataLength << 25) - 16;
It's probably wrong. Check the value you get from it.

RE: What we're doing - daniel0916 - 07-13-2014

(07-13-2014, 12:39 AM)FakeTruth Wrote: Fix this line
Code:
int UncompressedMaxSize = DataLength - (DataLength << 12) - (DataLength << 14) - (DataLength << 25) - 16;
It's probably wrong. Check the value you get from it.

It's the opposite of the compress code.
I use now 1000000 for testing.
Code:
char Output [1000000];
int success = uncompress((Bytef *)Output, (uLongf *)1000000, (const Bytef *)ChunkData.c_str(), (uLong)DataLength);
But then the uncompress crashes. Shouldn't i use c_str() or so?

RE: What we're doing - FakeTruth - 07-13-2014

(07-13-2014, 01:27 AM)daniel0916 Wrote:
(07-13-2014, 12:39 AM)FakeTruth Wrote: Fix this line
Code:
int UncompressedMaxSize = DataLength - (DataLength << 12) - (DataLength << 14) - (DataLength << 25) - 16;
It's probably wrong. Check the value you get from it.

It's the opposite of the compress code.
I use now 1000000 for testing.
Code:
char Output [1000000];
int success = uncompress((Bytef *)Output, (uLongf *)1000000, (const Bytef *)ChunkData.c_str(), (uLong)DataLength);
But then the uncompress crashes. Shouldn't i use c_str() or so?

I don't know. I don't know what ChunkData is, or what DataLength is, or what it holds.

You should definitely focus on this line though:
Code:
int UncompressedMaxSize = DataLength - (DataLength << 12) - (DataLength << 14) - (DataLength << 25) - 16;

I'm telling you, check the resulting value of that calculation, it's probably not what you expect. I expect a negative number.
Do you know what << means?

RE: What we're doing - xoft - 07-13-2014

(07-13-2014, 01:27 AM)daniel0916 Wrote: I use now 1000000 for testing.
Code:
char Output [1000000];
int success = uncompress((Bytef *)Output, (uLongf *)1000000, (const Bytef *)ChunkData.c_str(), (uLong)DataLength);
But then the uncompress crashes. Shouldn't i use c_str() or so?

Of course it crashes. The second parameter is all wrong. The function expects a pointer to memory where the buffer's length is stored, and it writes to that memory the actual number of bytes written. You're forcing a number down its throat instead of a pointer, so it tries to access memory at address 1000000. Most likely that address is not available for the program, so it crashes; but even if it didn't crash, it wouldn't work well for you.

You need to do this:
char Output [1000000];
uLongf BufferSize = sizeof(Output);
int success = uncompress((Bytef *)Output, &BufferSize, (const Bytef *)ChunkData.data(), (uLong)DataLength);
// BufferSize now contains the number of bytes actually uncompressed


RE: What we're doing - bearbin - 07-13-2014

Xoft, is that not a pointer to the length of the buffer, not the buffer itself?

RE: What we're doing - FakeTruth - 07-13-2014

(07-13-2014, 05:46 PM)bearbin Wrote: Xoft, is that not a pointer to the length of the buffer, not the buffer itself?

That's what he's sayingBig Grin

RE: What we're doing - xoft - 07-13-2014

Slightly edited to make it more comprehensible Smile

RE: What we're doing - daniel0916 - 07-13-2014

Okay, thanks.
Code:
char Output [1000000];
    uLongf BufferSize = sizeof(Output);
    int success = uncompress((Bytef *)Output, &BufferSize, (const Bytef *)ChunkData.data(), (uLong)DataLength);
    
    if (success != Z_OK)
    {
        return false;
    }
    
    if (!Packet.Write((const char *)Output, (size_t)BufferSize))
    {
        return false;
    }

Is this code right? Because the client disconnects because it's too big. I think i need to define on the Write method the writed size not the full size or?

RE: What we're doing - xoft - 07-13-2014

The client expects compressed data, so it will disconnect if you write uncompressed data to it.