+- Cuberite Forum (https://forum.cuberite.org)
+-- Forum: Cuberite (https://forum.cuberite.org/forum-4.html)
+--- Forum: Development (https://forum.cuberite.org/forum-13.html)
+--- Thread: Some refactoring needed? (/thread-242.html)
RE: Some refactoring needed? - xoft - 07-16-2012
It's easier to configure a single block, but it's become difficult to add some plugin customization to the actions - now the same plugin code needs to be added to each block, probably. Note, I haven't seen the changes too much yet, I'll have a look tomorrow.
Also, I think you've broken all of Cedeel's work
RE: Some refactoring needed? - Lapayo - 07-16-2012
I´ll look how to implement easy plugin custumization.
To the work for Cedeel:
This might probably be true, but I have contacted him and after explaining him, what I have planned he wasn´t responding
And I had so much spare time, that I wanted to do something.
(And I think it´s better to give the block the chance to say, if they can stay here or not
)
RE: Some refactoring needed? - NiLSPACE - 07-16-2012
i found a bug. you can't place redstone torches or normal torches.
RE: Some refactoring needed? - Lapayo - 07-17-2012
Thanks, it should be fixed in the current revision
RE: Some refactoring needed? - NiLSPACE - 07-17-2012
it works
but now a important (for me) repeaters don't work 
RE: Some refactoring needed? - Lapayo - 07-17-2012
Mhh, I will look into this issue
RE: Some refactoring needed? - NiLSPACE - 07-17-2012
thank you
RE: Some refactoring needed? - Lapayo - 07-17-2012
It was just a small problem, forgot entering the block id
(And unfortunately the client simluated the placement)Should be fixed in the current revision
RE: Some refactoring needed? - NiLSPACE - 07-17-2012
il try it
RE: Some refactoring needed? - xoft - 07-17-2012
I have some minor issues with the refactoring. Overall, it's a good change, just the tiny details
- Too many small files. Makes compilation take (quite a lot) longer.
- Using "char" instead of "NIBBLETYPE" for metas. currently, metas are handled as unsigned chars.
- Not using "override" for overridden virtual functions. Please, get used to this one, it's a really good practice to mark overridden functions, the compiler then checks if the function is really overriding something, and thus can catch some nasty typo bugs.