+- Cuberite Forum (https://forum.cuberite.org)
+-- Forum: Off Topic (https://forum.cuberite.org/forum-9.html)
+--- Forum: Off Topic Discussion (https://forum.cuberite.org/forum-10.html)
+--- Thread: Random Chitchat 2012-2016 (/thread-434.html)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
RE: What we're doing - xoft - 11-01-2012
Ah, that's just a "logging malfunction" - the log message is produced in the constructor. You can safely ignore that and I'll fix that somehow, later.
I like the patch now, just cosmetics remain: the #include-s for crypto can be left out. And the "login packet" that you're getting is probably just a leftover from some other packet (could be 0xfe - server list ping); in any case the constant for it needn't be defined ('cause you're not sending it).
Oh, and in cProtocolRecognizer, I've introduced names for the "magic number constants" - protocol versions. If you used that instead of "47", that'd be nice.
Now that you have all my criticism, you can commit the changes
Dinner's over, that concludes my today's involvement with MCS
RE: What we're doing - Luksor - 11-01-2012
Commited my changes as r1019.
EDIT: Pickups fixed in r1020.
RE: What we're doing - xoft - 11-02-2012
I'm cleaning up the time-related code. It has accumulated a lot of WTFs, so it needs refactoring. There are six variables that hold a world age / time (!?). That needs to go, or at least get properly documented.
With this change, we'll be able to properly send the world age / time of day to the new clients
Done in rev 1022.
Now we have two "times" for a world: The WorldAge and the TimeOfDay. The WorldAge is managed entirely by MCServer and is only incremented; no plugin is allowed to touch it. The TimeOfDay is manipulatable by plugins, and it wraps around each day.
The weird thing is, we need to accumulate sub-tick precision in the cWorld::Tick() function, so each of the times is actually stored in two forms: fractional seconds and integral ticks. The fractional seconds are primary, each tick they are incremented by the true amount of time passed, and then the tick values are calculated off of them (so that later the integral tick values can be used for performance reasons).
This also meant changing the Lua interface. I tried doing it the safest way - old functions will either map to new functions or return constants. Each obsolete function will emit a warning on the console with the instructions on how to fix it. So for example cWorld:GetTime() is obsoleted, always returns zero and says it should be replaced by cWorld:GetWorldAge() or cWorld:GetTimeOfDay().
I hope I didn't break too many things
The one thing that broke was Core's /time command, I fixed that.
RE: What we're doing - NiLSPACE - 11-12-2012
is there a way to turn off the fire simulator?
i found another bug. first its usefull (but cheating) after that the client crashes.
RE: What we're doing - FakeTruth - 11-12-2012
Oh wow WTF! That's very surprising
RE: What we're doing - Taugeshtu - 11-12-2012
I can confirm that this bug exist, and it does crash clients. "It was all fun and games until someone had memory outrun"
RE: What we're doing - Luksor - 11-12-2012
When you move your cursor from one block to another while holding your left mouse button the clients sends a "Player Digging" packet with status "2" - that means the digging is finished (at least in 1.3). There were probably some changes in 1.4.2. No updated documentation on wiki.vg yet.
RE: What we're doing - Luksor - 11-12-2012
I fixed the bug! I don't think my solution is the most optimal so I'll show you the patch first.
https://dl.dropbox.com/u/21041937/Bugfix.patch
RE: What we're doing - xoft - 11-12-2012
I think the patch is alright; I only have an issue with the condition - could you put some extra parenthesis in there, so that it's immediately clear what compares to what?
I really hate stuff like "if (A || B && C)" - does it first do the || or the &&? And why should I have to think about it? "if ((A || B) && C)" is so much clearer.
Also, a comment about why the condition is so complicated would be welcome.
RE: What we're doing - Luksor - 11-12-2012
OK. Bug fixed in r1038.
