+- Cuberite Forum (https://forum.cuberite.org)
+-- Forum: Plugins (https://forum.cuberite.org/forum-1.html)
+--- Forum: Plugin Releases (https://forum.cuberite.org/forum-2.html)
+--- Thread: Core (/thread-4.html)
RE: [Plugin] Core V7 - NiLSPACE - 10-25-2013
(10-25-2013, 12:09 AM)xoft Wrote: Show me a comparison, I still believe it would look better detached.
(10-25-2013, 12:09 AM)xoft Wrote: Maybe move the MoveUp / MoveDown buttons to the left and make the plugin name column expand, so that all the buttons on the page align on the right side?
I think the length of the column is determinant by the plugin with the longest name, so I don't think I can do much about it.
RE: [Plugin] Core V7 - FakeTruth - 10-25-2013
Add this to the first td or th
Code:
<th width="100%">...</th>RE: [Plugin] Core V7 - xoft - 10-25-2013
Now lose the table around the headers, make them regular <h2> or whatever level is appropriate, and add a sentence to each ("These plugins are currently running", "These plugins encountered an error while starting up", "These plugins are disabled in the configuration")
RE: [Plugin] Core V7 - NiLSPACE - 10-25-2013
I don't realy understand everything. Maybe you can edit it yourself and then post the result here so we can compare?
The lines are: 92, 112 and 122(just noticed that there is a tab missing).
RE: [Plugin] Core V7 - xoft - 10-25-2013
Is that the ReWrite branch of the Core project, or some other repo?
RE: [Plugin] Core V7 - NiLSPACE - 10-25-2013
The ReWrite branch.
RE: [Plugin] Core V7 - xoft - 10-25-2013
I've tried to make the changes, but I'm not a web designer, so it looks crummy, but I think it captures the idea.
Your version:
My version:
Also, your rewrite is lacking the console /reload command, and that sux
Reloading through the web interface causes crashes for some reason - probably cPluginManager not being thread-safe when reloading plugins.
RE: [Plugin] Core V7 - FakeTruth - 10-25-2013
I'm not sure if that much text is necessary
I mean "Active plugins" > "These plugins are active" really? haha.But yeah whatever, personally I don't have a preference, I think both versions look good. It would make sense to remove the colored text though, since it's already categorized.
RE: [Plugin] Core V7 - xoft - 10-25-2013
I was hoping someone would come up with something more clever to put there; it makes sense to have the text for Errors and Disabled, and I didn't think it'd look good to have no text for the Active.
I've committed my quick changes as a ReWrite_pluginlist branch, feel free to experiment with it.
I've come up with a nicer text, just for you
I question the correctness of the plugin - it displays ErrPlgB in both Active and Errors.
It should be in Errors only, because it's only an empty folder (no file -> no Initialize() function, so it fails to load)
RE: [Plugin] Core V7 - NiLSPACE - 10-25-2013
I have to say that it looks much better then I expected
I'm now working on the bug where an plugin with an empty folder shows up in both Error and Active.