[DONE] Groups and permissions refactor - Printable Version +- Cuberite Forum (https://forum.cuberite.org) +-- Forum: Cuberite (https://forum.cuberite.org/forum-4.html) +--- Forum: Development (https://forum.cuberite.org/forum-13.html) +--- Thread: [DONE] Groups and permissions refactor (/thread-1540.html) |
RE: Groups and permissions refactor - xoft - 08-12-2014 I have cobbled together some sort of a basic UI for the ranks. It's not pretty, but it gets the job done; I'll leave the beautification part on the more web-experienced coders here. It's all in the Ranks PR / branch: https://github.com/mc-server/Core/pull/83 Permissions page: Editing group: Ranks page: Editing rank's groups: Editing rank visuals: Player list: Player details: Sending a PM: RE: Groups and permissions refactor - NiLSPACE - 08-12-2014 That looks great I do have a question though: The Player details page shows "Permissions *" for you, but what would it show when there is someone with a "normal" list with permissions? RE: Groups and permissions refactor - xoft - 08-12-2014 It lists all the permissions: RE: Groups and permissions refactor - NiLSPACE - 08-12-2014 That could get pretty big. RE: Groups and permissions refactor - bearbin - 08-12-2014 Does this interface support changing permissions for offline users? That's a pretty essential feature. RE: Groups and permissions refactor - xoft - 08-12-2014 It doesn't, yet. Do you have any recommendations about what it should look like, how to integrate it? RE: Groups and permissions refactor - bearbin - 08-12-2014 I'd recommend removing the rank changing from the player details page, and create a new page - "Player Permissions" or something. There should be an easy lookup feature - just type in the name and jump to a player, and also a list of everybody and what rank they have (plus a dropdown and save button for each player to change the rank). RE: Groups and permissions refactor - xoft - 08-13-2014 I'm writing a migration path, so that the server auto-migrates from INI files to SQLite DB, and I've hit some kind of a performance bottleneck. Processing just 80 players takes 10 seconds! WhatTheFunction?!? RE: Groups and permissions refactor - xoft - 08-13-2014 Something's seriously wrong. I've just retried the same code with VS2013 on a slightly faster computer and it takes a fraction of a second. Did the VS optimizer get really that good? Do I really write such a poor code? RE: Groups and permissions refactor - worktycho - 08-13-2014 They did put a lot of work into MSVC's optimiser in the last couple of cycles. Also how much newer if the cpu in the faster computer? A lot of the recent processors have got more performance per cycle. Also your moving around a lot of strings in the code so you may be benefiting form move constructors. People have seen 5-10% gains on some code purely from turning on the c++11 standard libs. |