+- Cuberite Forum (https://forum.cuberite.org)
+-- Forum: Cuberite (https://forum.cuberite.org/forum-4.html)
+--- Forum: Discussion (https://forum.cuberite.org/forum-5.html)
+--- Thread: Expanding & Overviewing the map (/thread-1662.html)
RE: Expanding & Overviewing the map - wudles - 11-29-2014
OK. Tracked it down. It comes down to our storage format.
There is no modification time set for our chunks, and the overviewer rejects any chunks without an mtime.
RE: Expanding & Overviewing the map - xoft - 11-29-2014
That should be fairly easy to fix - whenever storing a chunk, store its modification time ("time(nullptr)") as well.
RE: Expanding & Overviewing the map - wudles - 11-29-2014
(11-29-2014, 07:41 AM)xoft Wrote: That should be fairly easy to fix - whenever storing a chunk, store its modification time ("time(nullptr)") as well.
Yup. Need another coder? I don't mind adding to this, but I don't want to step on any toes.
RE: Expanding & Overviewing the map - xoft - 11-30-2014
Are you kidding? We always welcome new people willing to donate code. Feel free to submit a PR on GitHub with this change.
RE: Expanding & Overviewing the map - wudles - 11-30-2014
Checking out the Anvil storage mechanism over some turkey soup today.
RE: Expanding & Overviewing the map - wudles - 12-04-2014
Well, I have the mtime stored now, but it looks like like the ChunkWorx plugin doesn't quite generate everything.
Areas I have acutally been in show as lit up, areas generated by ChunkWorx are dark.
http://minecraft.planetx.com/
RE: Expanding & Overviewing the map - xoft - 12-04-2014
Right, ChunkWorx doesn't light the chunks, it only generates the terrain. We need to do some work on this. The plugin is ripe for a rewrite anyway.
RE: Expanding & Overviewing the map - xoft - 12-04-2014
Plan of action:
- Implement a cWorld::PrepareChunk() method that either loads the chunk from disk or generates it, as needed, and lights it.
- (Use that function in cSpawnPrepare for cWorld - https://github.com/mc-server/MCServer/issues/1615 )
- Export the function to Lua
- Change the ChunkWorx plugin to use the function instead of cWorld:TouchChunk()
- Change the ChunkWorx plugin to use a better queueing and smarter chunk ordering.
RE: Expanding & Overviewing the map - wudles - 12-05-2014
I'll submit the first needed changes to WSSAnvil.cpp/h today or tomorrow. (It's barely 2 dozen lines of code.)
As to lua, this is my first experience. I'm a VLSI and hardware drivers guy -- mainly for crypto. I'll have a look at cWorld and what you are doing there this weekend.
RE: Expanding & Overviewing the map - wudles - 12-05-2014
(11-30-2014, 05:18 AM)xoft Wrote: Are you kidding? We always welcome new people willing to donate code. Feel free to submit a PR on GitHub with this change.
The create PR button is disabled for me.
Here are the two files.