+- Cuberite Forum (https://forum.cuberite.org)
+-- Forum: Cuberite (https://forum.cuberite.org/forum-4.html)
+--- Forum: Development (https://forum.cuberite.org/forum-13.html)
+--- Thread: "Never merge your own PR" (/thread-1974.html)
"Never merge your own PR" - LogicParrot - 05-23-2015
We could have a "Never merge your own PR" policy, it forces each line of code to be reviewed at least twice before making it into master.
RE: "Never merge your own PR" - bearbin - 05-23-2015
That's a good policy. I'll at least try and do it myself.
RE: "Never merge your own PR" - LogicParrot - 05-23-2015
I'm doing it too.
RE: "Never merge your own PR" - xoft - 05-23-2015
That could get a bit difficult for me
Hardly anyone wants to review my changes, except for nitpicking some comment typos. So I at least try to have the PR open for a day and merge if there are no comments.