+- Cuberite Forum (https://forum.cuberite.org)
+-- Forum: Cuberite (https://forum.cuberite.org/forum-4.html)
+--- Forum: Development (https://forum.cuberite.org/forum-13.html)
+--- Thread: Pull request handling (/thread-2029.html)
Pull request handling - xoft - 06-30-2015
I'd like to propose a new bit of guideline to handling the PRs.
We should try to make the history "less tangled" by requesting all PRs be rebased onto current master just before merging. We want to avoid this:
![[Image: repo_tracks.png]](http://mc-server.xoft.cz/img/repo_tracks.png)
How about that?
RE: Pull request handling - bearbin - 06-30-2015
I'd agree, make a request and hopefully make the history a bit cleaner, but don't make it a hard requirement for getting a PR merged.
RE: Pull request handling - NiLSPACE - 06-30-2015
Perhaps make a small tutorial on how to squash or rebase a PR in the guidelines of making a PR.
RE: Pull request handling - SamJBarney - 07-01-2015
(06-30-2015, 08:10 PM)NiLSPACE Wrote: Perhaps make a small tutorial in the guidelines of making a PR.
I agree. Knowing the correct format and how they should be handled would be beneficial. The format has changed since I was here last, and it would be nice to have a tutorial so I can get up to speed on it.