Cuberite Forum
Submitting changes as github newbie - Printable Version

+- Cuberite Forum (https://forum.cuberite.org)
+-- Forum: Cuberite (https://forum.cuberite.org/forum-4.html)
+--- Forum: Development (https://forum.cuberite.org/forum-13.html)
+--- Thread: Submitting changes as github newbie (/thread-3178.html)



Submitting changes as github newbie - catfishery - 05-11-2018

Hello,

I made some changes to the code that I want to commit to the github repository. Unfortunately I'm kind of a github newbie.

I created a local branch, so I can push the changes to the repository and then hopefully merge them to the master branch via pull request. But when I try to push the local branch, I get the following error message: "remote: Permission to cuberite/cuberite.git denied to <username>."

What am I missing? Is this even the correct way to go?


RE: Submitting changes as github newbie - NiLSPACE - 05-11-2018

Hi,

You have to fork the Cuberite repository (top right) in the [url=https://github.com/cuberite/cuberiteCuberite repository on Github[/url]. After that you can clone that repo. The URL would be this: https://github.com/catfishery/cuberite. You will be able to push to this repository and create pull requests from there.


RE: Submitting changes as github newbie - catfishery - 05-11-2018

(05-11-2018, 05:28 AM)NiLSPACE Wrote: Hi,

You have to fork the Cuberite repository (top right) in the [url=https://github.com/cuberite/cuberiteCuberite repository on Github[/url]. After that you can clone that repo. The URL would be this: https://github.com/catfishery/cuberite. You will be able to push to this repository and create pull requests from there.

Thanks a lot, will give it a try.

EDIT: Alright, created a PR; worked like a charm. Thanks again!


RE: Submitting changes as github newbie - catfishery - 05-12-2018

Sorry for double post, but what's the way to go if I find a bug and wanna provide an idea on how to fix it, but since I just started looking into cuberite's code I might miss some things that more experienced developers recognize immediately? Is a PR the place to discuss such things? Or should I open a github issue for that?


RE: Submitting changes as github newbie - NiLSPACE - 05-12-2018

If there already is an issue made on Github for that bug you can discuss it there. Otherwise you can open a new issue.