+- Cuberite Forum (https://forum.cuberite.org)
+-- Forum: Cuberite (https://forum.cuberite.org/forum-4.html)
+--- Forum: Development (https://forum.cuberite.org/forum-13.html)
+--- Thread: Getting involved (/thread-3240.html)
Pages:
1
2
RE: Getting involved - e14 - 09-17-2019
(09-12-2019, 06:48 PM)xoft Wrote: Is there anything that would have made you aware of those settings before? Something we could improve? Perhaps listing those values at the end of the configure process, as a summary?I think it's fine, when you mentioned it I hadn't thought much about the tools yet, I wondered how they were built but it wasn't a priority, you telling me was just perfect timing.
A different question, what are your goals for compiler compatibility? My distro comes with clang 8 and cuberite won't compile with that (at least in DEBUG) due to -Werror and -Wextra-semi-stmt (Which is included in some of the other) switches and probably others strewn across the project, and I'm wondering whether it makes sense to create some pull requests to try and fix those.
RE: Getting involved - xoft - 09-23-2019
Congratulations on getting involved
RE: Getting involved - e14 - 09-23-2019
(09-23-2019, 06:58 AM)xoft Wrote: Congratulations on getting involved... Thanks - About my question? Or should I make a new thread?
Quote:A different question, what are your goals for compiler compatibility? My distro comes with clang 8 and cuberite won't compile with that (at least in DEBUG) due to -Werror and -Wextra-semi-stmt (Which is included in some of the other) switches and probably others strewn across the project, and I'm wondering whether it makes sense to create some pull requests to try and fix those.
RE: Getting involved - xoft - 09-23-2019
Sorry, I missed that question altogether (real life catching up and giving me a headache).
There was a PR to fix the extra semicolons, so I considered it fixed: https://github.com/cuberite/cuberite/pull/4346 . If it's still not fixed, we definitely want to support the newest compilers, so PRs to fix any issues will be welcome, as long as they make sense (there has been some discussion about semicolons vs macros in that PR).
What other kinds of errors do you get?
RE: Getting involved - Seadragon91 - 09-25-2019
Did a check for clang 8. Updated my clang and it's version 8.0.1. Got the same errors that @e14 posted
/home/lukas/cpp/cuberite/src/Protocol/Protocol_1_13.cpp:231:64: error: empty expression statement has no effect;
remove unnecessary ';' to silence this warning [-Werror,-Wextra-semi-stmt]
HANDLE_READ(a_ByteBuffer, ReadVarUTF8String, AString, Channel);
^
/home/lukas/cpp/cuberite/src/Protocol/Protocol_1_13.cpp:236:63: error: empty expression statement has no effect;
remove unnecessary ';' to silence this warning [-Werror,-Wextra-semi-stmt]
HANDLE_READ(a_ByteBuffer, ReadVarUTF8String, AString, Brand);
^
/home/lukas/cpp/cuberite/src/Protocol/Protocol_1_13.cpp:392:64: error: empty expression statement has no effect;
remove unnecessary ';' to silence this warning [-Werror,-Wextra-semi-stmt]
HANDLE_PACKET_READ(a_ByteBuffer, ReadBEInt16, Int16, ItemType);
^
/home/lukas/cpp/cuberite/src/Protocol/Protocol_1_13.cpp:401:63: error: empty expression statement has no effect;
remove unnecessary ';' to silence this warning [-Werror,-Wextra-semi-stmt]
HANDLE_PACKET_READ(a_ByteBuffer, ReadBEInt8, Int8, ItemCount);
RE: Getting involved - Bond_009 - 09-25-2019
Should be fixed by https://github.com/cuberite/cuberite/pull/4399
RE: Getting involved - Seadragon91 - 09-26-2019
Yes that corrects it, thanks @Bond_009.