Random Chitchat 2012-2016 - Printable Version

Cuberite Forum

Random Chitchat 2012-2016 - Printable Version

+- Cuberite Forum (https://forum.cuberite.org)
+-- Forum: Off Topic (https://forum.cuberite.org/forum-9.html)
+--- Forum: Off Topic Discussion (https://forum.cuberite.org/forum-10.html)
+--- Thread: Random Chitchat 2012-2016 (/thread-434.html)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487

RE: What we're doing - NiLSPACE - 08-28-2014

And I'm just sitting here in my class room Wink

Wink

Have fun there Big Grin

Big Grin

RE: What we're doing - xoft - 08-28-2014

Well, you're sitting in your classroom browsing through MCServer forum, that's not so bad either. Back in my days we had to pay attention at school Big Grin

Big Grin

RE: What we're doing - NiLSPACE - 08-28-2014

I hope you had better teachers then our math teacher, because he didn't show up. Tongue

Tongue

RE: What we're doing - LO1ZB - 08-28-2014

It is supposed, that params at places like this:

Code:
    inline static void SetBiome(BiomeMap & a_BiomeMap, int a_X, int a_Z, EMCSBiome a_Biome)

    {

        ASSERT((a_X >= 0) && (a_X <= Width));

        ASSERT((a_Z >= 0) && (a_Z <= Width));

        a_BiomeMap[a_X + Width * a_Z] = a_Biome;

    }

are only checked for validity in debug mode?
I'm asking, because MSVS is giving me that warning after I run code analysis tool.

http://msdn.microsoft.com/en-us/library/ww5t02fa.aspx

RE: What we're doing - LO1ZB - 08-28-2014

GitHub is confusing me :O
I only want to create a pull request :/

EDIT:
I switch base and head and now its working. Smile

Smile

RE: What we're doing - tigerw - 08-28-2014

(08-28-2014, 06:07 PM)LO1ZB Wrote: It is supposed, that params at places like this:

Code:
inline static void SetBiome(BiomeMap & a_BiomeMap, int a_X, int a_Z, EMCSBiome a_Biome) { ASSERT((a_X >= 0) && (a_X <= Width)); ASSERT((a_Z >= 0) && (a_Z <= Width)); a_BiomeMap[a_X + Width * a_Z] = a_Biome; }
are only checked for validity in debug mode?
I'm asking, because MSVS is giving me that warning after I run code analysis tool.

http://msdn.microsoft.com/en-us/library/ww5t02fa.aspx

Yes, the ASSERT macro is emptied in Release builds.

That's a good point though, what if something tries to write to a_BiomeMap[16 + Width * 16] (a_BiomeMap[272])?

RE: What we're doing - xoft - 08-28-2014

The asserts seem wrong, the comparison to Width should not include equality.
Does VS give you any more information on this particular warning, such as the steps required to reproduce it?

RE: What we're doing - LO1ZB - 08-28-2014

(08-28-2014, 09:05 PM)xoft Wrote: The asserts seem wrong, the comparison to Width should not include equality.
Does VS give you any more information on this particular warning, such as the steps required to reproduce it?

Not for this one. (1 of 32 read/write overflow warnings)
But I think i know what the problem is.
ChunkDev.h line 78

Code:
typedef EMCSBiome BiomeMap[Width * Width];

the leght of BiomMap is 256 -> index 0-255

Code:
    inline static void SetBiome(BiomeMap & a_BiomeMap, int a_X, int a_Z, EMCSBiome a_Biome)

    {

        ASSERT((a_X >= 0) && (a_X <= Width));

        ASSERT((a_Z >= 0) && (a_Z <= Width));

        a_BiomeMap[a_X + Width * a_Z] = a_Biome;

    }

if a_X and a_Z are 16
a_X + Width * a_Z = 16 + 256 = 272
This would corret the warning:

Code:
    inline static void SetBiome(BiomeMap & a_BiomeMap, int a_X, int a_Z, EMCSBiome a_Biome)

    {

        VERIFY((a_X >= 0) && (a_X <= Width));

        VERIFY((a_Z >= 0) && (a_Z <= Width));

        a_BiomeMap[(a_X * a_Z) - 1 ] = a_Biome;

    }

RE: What we're doing - xoft - 08-28-2014

Your change may correct the warning, but it's the wrong code. You need to keep the index calculation as is, and change only the condition inside the ASSERTs, from "a_X <= Width" to "a_X < Width"; if the warning stays, then someone's calling the function wrong and we have to find the bad caller.

RE: What we're doing - NiLSPACE - 08-29-2014

Well.. my school wants everyone to buy their own domain so they can eventualy upload their website on it. Any suggestions? Tongue

Tongue