+- Cuberite Forum (https://forum.cuberite.org)
+-- Forum: Cuberite (https://forum.cuberite.org/forum-4.html)
+--- Forum: Development (https://forum.cuberite.org/forum-13.html)
+--- Thread: Lua hooks needed! (/thread-464.html)
RE: Lua hooks needed! - xoft - 01-13-2013
Just found out that I'm stupid. I forgot to commit half of the merged files. Hopefully all's fixed in rev 1140.
RE: Lua hooks needed! - bearbin - 01-14-2013
Just a few suggestions about the settings,ini file.
You have hooknotify enabled. Shouldn't that be for devleopers only? Also the debuggers plugin is in twice, once commented out and once not.
RE: Lua hooks needed! - xoft - 01-14-2013
Fixed in rev 1141. It got there from the branch by accident.
RE: Lua hooks needed! - bearbin - 01-14-2013
OK, cool
RE: Lua hooks needed! - Taugeshtu - 01-19-2013
Source Wrote:cPluginManager.HOOK_PLAYER_LEFT_CLICKWHAAAAAAT?! I suggest using HOOK_PLAYER_LEFTCLICK & HOOK_PLAYER_RIGHTCLICK.
cPluginManager.HOOK_PLAYER_RIGHTCLICK
RE: Lua hooks needed! - bearbin - 01-19-2013
Yeah, that is a bit inconsistent
RE: Lua hooks needed! - xoft - 01-19-2013
Must've been asleep when writing that
The question is, do we consider "leftclick" and "rightclick" single words? Because all the other hooks use underscores between each word.
I'm going with underscore, since we also have pre-crafting transcribed as HOOK_PRE_CRAFTING.
RE: Lua hooks needed! - xoft - 01-20-2013
Ok, it seems the current hooks are stable enough, so now it's time to go crazy about the new hooks. And since forum isn't really an efficient way of doing this kind of stuff, how about we use the bugtracker for this?
So I invite anyone having an idea for a hook to write it down in the bugtracker, possibly as a "feature request" task type and start the summary with "New hook: ..."; use one issue for one hook or one group of related hooks (for example, "inventory window hooks"); try to describe what the hooks should cover, when exactly they should fire, what parameters you'd recommend, what actions to take if the hook callback returns true (what kind of cleanup should MCServer do, if any at all), maybe some example usage, etc. The more information you provide, the more attractive it will be to us developers and thus more likely to get implemented soon
Thank you all in advance.
RE: Lua hooks needed! - NiLSPACE - 01-20-2013
Maybe FakeTruth can create a new project in the bugtracker for hook requests
RE: Lua hooks needed! - bearbin - 01-21-2013
Maybe not specifically hook requests, the API as a whole?