Enchanting

[SamJBarney]

Do arrows actually get used up? I've been looking around, and I can't seem to find where that happens.

[daniel0916]

Yes, the arrows will be used and removed from the inventory. I also can't find it ...

[tigerw]

All completely clientside I think.

[xoft]

src/Items/ItemBow.h line 78:

if (!a_Player->IsGameModeCreative())
{
	a_Player->UseEquippedItem();
}

EDIT: Wait, no, that only decreases bow durability. Then the arrows aren't removed server-side.

[SamJBarney]

So arrow use hasn't been actually implemented yet. Huh.

[daniel0916]

So when the client remove the arrow from the inventory, mcserver don't remove it or? Then the server and client are out of sync.

EDIT: Yes, it is so. You can duplicate arrows. I will fix this.
EDIT2: Give it a method to search in the inventory for a item?

[tigerw]

I think you'll have to make a method yourself: that was one reason why it wasn't fixed a long time back :P

[daniel0916]

Where should i add the checks for the protection enchantments?
In the "TakeDamage" method or in the "GetArmorCoverAgainst" method?

[xoft]

Based on the armor wiki page, I think the TakeDamage function is a better place for that calculation (but implement the core calculation in a separate function, called by TakeDamage)

Ref.: http://minecraft.gamepedia.com/Armor#Enchantments

[tonibm19]

Are you still working on this? If you aren't you could maybe do a PR of actually implemented enchantments