Missing lines in crafting.txt

[Jammet]

I don't know why this was not in crafting.txt yet, but once I put it there, I was finally able to make Stained Clay.

Should probably put into the crafting.txt of the distribution, too? Maybe something else is missing in there?

Code:

#******************************************************#
# Stained Clay:
#
WhiteStainedClay, 8     = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | BoneMeal, 2:2
OrangeStainedClay, 8    = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | OrangeDye, 2:2
MagentaStainedClay, 8   = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | MagentaDye, 2:2
LightBlueStainedClay, 8 = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | LightBlueDye, 2:2
YellowStainedClay, 8    = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | YellowDye, 2:2
LimeStainedClay, 8      = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | LimeDye, 2:2
PinkStainedClay, 8      = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | PinkDye, 2:2
GrayStainedClay, 8      = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | GrayDye, 2:2
LightGrayClay, 8        = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | LightGrayDye, 2:2
CyanStainedClay, 8      = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | CyanDye, 2:2
VioletStainedClay, 8    = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | VioletDye, 2:2
BlueStainedClay, 8      = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | BlueDye, 2:2
BrownStainedClay, 8     = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | BrownDye, 2:2
GreenStainedClay, 8     = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | GreenDye, 2:2
RedStainedClay, 8       = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | RedDye, 2:2
BlackStainedClay, 8     = HardenedClay, 1:1, 1:2, 1:3, 2:1, 2:3, 3:1, 3:2, 3:3 | BlackDye, 2:2

[xoft]

Nice catch. Feel free to make the change yourself on GitHub.
It is perfectly possible that some other recipes are missing, it's not like we check each and every one of them when MC releases a new version. If you find any recipe missing, add them in the repo.

[Jammet]

I've never done anything like that before. I'll try to figure out how that works.

About Stained .. glass, clay, what have you, this still leaves the problem that dyes are in crafting.txt, but they don't work at all. I can put red and yellow flowers into a crafting box or table and try to make dye out of them to no avail. Maybe again there is something off with the ordering of lines in crafting.txt, but I don't see roses or flowers used for anything else, so ...

It says I can only "fork and edit". XD Clearly I am not a dev and shouldn't be messing with your project files.

[worktycho]

If you fork and edit you can then submit the changes back in a pull request.

[xoft]

The StainedXYZ problems are fixed in a PullRequest: https://github.com/mc-server/MCServer/pull/1864
I'm hoping to get it merged soon.

[Jammet]

So, should I try to do this PullRequest thing?

Hehe .. this may be a dumb question in a way, but to me, this is all new terretory. So what I just read basically amounts to:

You have to twist the pulley counterclockwise and attach it to the relectoncrest, lift up the teleftic zwirangle and request a fried chicken...

[worktycho]

Yes, the point is it allows everyone to look at the changes before they are added to the main code base. Even those of us with commit access use them to make changes to master branch so that everyone can discuss the changes.

[Jammet]

I will give it a try.