Brewing status - Merged

Seadragon91 · 06-17-2015, 05:48 AM

Okay, the exported methods for the api works fine Big Grin

If someone wants and has time, look at my brewing code and comment it for improvements / fixes or looking at the missing features with progress-bar and the click handle problem in SlotArea.cpp.

Seadragon91 · (This post was last modified: 06-17-2015, 01:55 PM by Seadragon91.)

Have squashed all commits into one commit for easier review.

Edit: Should I make a pull request for better commenting on github?

xoft · 06-17-2015, 03:51 PM

Definitely do.

Seadragon91 · (This post was last modified: 06-18-2015, 05:22 AM by Seadragon91.)

Progress bars are now working fine Big Grin

Seadragon91 · (This post was last modified: 06-30-2015, 04:06 AM by Seadragon91.)

I was able to fix the slot handling problem. The brewing recipes needs a whole rework, is more trickier then I had thought and the list would be very big...

Seadragon91 · (This post was last modified: 09-26-2015, 03:37 AM by Seadragon91.)

Have recreated a pull request for it. Let's review and discuss it.

Seadragon91 · (This post was last modified: 10-12-2015, 02:53 AM by Seadragon91.)

Added hooks

Brewing process is completing
Brewing process is completed

I am not sure, if I should add a array in Brewinstand.h, that contains the result items for the bottle slots. This can be accessed from lua.

Jammet · 10-16-2015, 09:24 PM

I'm going to test this stuff a lot once it's merged into the main branch Smile

.

Seadragon91 · (This post was last modified: 10-16-2015, 10:02 PM by xoft.)

(10-16-2015, 09:24 PM)Jammet Wrote: I'm going to test this stuff a lot once it's merged into the main branch .

I could compile a current windows cuberite version with the brewing included for you, if you want.

Jammet · 10-18-2015, 05:39 AM

That's nice, but I'm running this on arm architecture. I'm cool with waiting, and once it's there, like, for everybody, gonna do a lot of brewin' Wink

.