12-13-2015, 12:31 AM
(This post was last modified: 12-17-2015, 02:45 AM by LogicParrot.)
Current merge rules are too inconvenient
|
Thanks given by: NiLSPACE
12-13-2015, 02:10 AM
Yes. This got disabled a while ago, how come it got re-enabled?
Because we need to require status checks. Protected branches shouldn't be blocking merges from my understanding of githubs docs.
Looking closer, it looks like if you enable required status checks, it blocks if the branch is not up to date with master. So you can't have the required status checks feature, and the ability to merge out of date PR's.
12-13-2015, 03:37 PM
(This post was last modified: 12-13-2015, 04:15 PM by LogicParrot.)
Quote:Because we need to require status checks.Can't we just ask people not to commit directly into `master` and not to merge before CI finishes? Do "status checks" provide any other features we use?
The don't force push master setting is separate, so we can keep that.
I'm going to try disabling this for a couple of weeks, and see what happens.
12-14-2015, 09:16 AM
We've had some trigger-happy people who would merge even before the CI completed, let alone some review from the others. I hope those are now educated enough
![]()
12-17-2015, 02:43 AM
1. Blocking merges whose CI did not succeed / has not finished
2. Blocking merges whenever master is ahead of them by one or more commits These sound like two seperate options to me. Are they interwined in Github for some reason? |
« Next Oldest | Next Newest »
|
Users browsing this thread: 2 Guest(s)