Poll: What to do with multi-version suport?

xoft · (This post was last modified: 10-26-2012, 04:43 AM by xoft.)

If I read correctly, the 1.4 version of Minecraft has the ability to detect server version and will refuse to connect to an older a different version. This makes it somewhat difficult for us regarding our multi-version support. These solutions come to mind, without much thinking them through. Let's discuss Smile

(A) We drop multi-version support altogether. We keep the architecture, because it makes version transitions easier, but we don't use it to support multiple protocols

(B) We let the server admin specify which version they want supported through an ini file, that version will be reported to the client. Multi-version support will be there in the background, but effectively will not be used other thanthat.

© We let the server admin specify multiple server ports and versions on each port. One single port will have one version, but there can be more versions supported simultaneously on different ports.

So Mojang decided that they want the players to need to be aware of the technical stuff, connecting to different ports etc., instead of the server working on the details and deciding about the support. Nice Tongue

Luksor · (This post was last modified: 10-26-2012, 05:41 AM by Luksor.)

(D) Take client's version from the handshake and send it back to him as the server version to enable the client to connect. Smile

Still, I think that multi-version support should be removed in the future. It will bring tons of bugs as more features will be added.
New blocks or mobs will crash older clients, and there can be more advanced changes than that. Not just some packets in the protocol. I don't think it's worth the effort.

ThuGie · 10-26-2012, 05:39 AM

I would go fror dropping it, even though its nice to have.
In the long run wouldnt it become a mess to keep it up ?

xoft · (This post was last modified: 10-26-2012, 05:51 AM by xoft.)

It will be a mess to drop, actually, because someone would need to go through all versions and decide if their code is needed for the newer version or not (thanks to C++ inheritance, the 1.3.2 protocol actually uses the 1.2.5 protocol's functions for the packets that didn't change). And as I've already written, it makes for an easier transition between two protocol versions - you can have both protocols enabled and only advanced users / testers try out the new protocol and report bugs, while others can keep working on other stuff.

(10-26-2012, 05:35 AM)Luksor Wrote: (D) Take client's version from the handshake and send it back to him as the server version to enable the client to connect.

If that is possible, it will be the best solution. But I'm afraid the server version is reported in the protocol sooner than a handshake (I suspect the "0xff server ping" packet will have the info, which is sent without the handshake)

Luksor · (This post was last modified: 10-26-2012, 06:17 AM by Luksor.)

Hahaha! A little bug i just found:
If you want to connect to an older server using 1.4 client select the server you want to connect to, click "direct connect" then "cancel" and finally "join server". Enjoy Big Grin

EDIT: Another solution (at least to when Minecraft 1.5 will be out): Make server send his version as 1.4, older clients will probably ignore it and connect anyway and 1.4 client will be able to connect too without using any tricks. Tongue

ThuGie · 10-26-2012, 06:12 AM

Just wondering though.
If you send the server is a 1.4
How do old clients respond as they shouldnt deny access right ?

xoft · (This post was last modified: 10-26-2012, 06:19 AM by xoft.)

The first problem is that the first packet that the client sends has changed between the versions:
http://wiki.vg/Pre-release_protocol#Serv....280xFE.29
The list ping packet used to be a single byte (packet type), now it's two bytes; but the server doesn't know, if it receives a single byte, if it should wait or not for another byte to come.

The second problem is that if the server sent a 1.4 version, the <=1.3.2 clients would display garbled server name instead of "MCServer - in C++, 0/100 players".

The poll results are really nice right now Smile

33%, 33%, 33%, one person for each option.

Luksor · 10-26-2012, 06:25 AM

Oh. So now I'm opting for (A) then. Tongue

FakeTruth · (This post was last modified: 10-26-2012, 11:08 AM by FakeTruth.)

Mojang must hate MCServer :p

xoft · 11-09-2012, 07:21 AM

In the end, multi-protocol support stays in and the server admin decides, which protocol version MCServer reports to the clients, using settings.ini: [Server].PrimaryServerVersion
I've added a detailed description to the wiki, hopefully it's clear enough. http://www.mc-server.org/wiki/doku.php?i...er_section

Poll: What to do with multi-version suport? You do not have permission to vote in this poll.
(A) Drop it	54.55%	6	54.55%
(B) Let admin select	36.36%	4	36.36%
© Multiple versions on multiple ports	9.09%	1	9.09%
Total		11 vote(s)	100%