1.8 Changes
#12
I think you're doing some very wrong things.
First of all AFAIK a long is 4 bytes (=32 bits) and you're shifting it 38 bits. This will most definitely result in overflow of the value.
Second -not really a problem- is the way you use LOGWARN. The log function takes a formatted string so you should write LOGWARN("%i", x); instead of the whole std::to_string() stuff.

Last this totally blows my mind:
Code:
long z2 = value << 38 >> 38;
The order in which the shifts occur is not clear at all. And you're shifting it with the same value to both sides which should result in no change? idk.. confusing.

Do you know what you're doing or are you just trying something?Tongue
Reply
Thanks given by:


Messages In This Thread
1.8 Changes - by daniel0916 - 02-03-2014, 01:37 AM
RE: 1.8 Changes - by daniel0916 - 02-03-2014, 05:04 AM
RE: 1.8 Changes - by xoft - 02-03-2014, 05:18 AM
RE: 1.8 Changes - by daniel0916 - 02-03-2014, 05:38 AM
RE: 1.8 Changes - by daniel0916 - 02-04-2014, 12:41 AM
RE: 1.8 Changes - by worktycho - 02-04-2014, 02:56 AM
RE: 1.8 Changes - by daniel0916 - 02-04-2014, 04:12 AM
RE: 1.8 Changes - by worktycho - 02-04-2014, 04:27 AM
RE: 1.8 Changes - by daniel0916 - 02-04-2014, 05:00 AM
RE: 1.8 Changes - by xoft - 02-04-2014, 05:04 AM
RE: 1.8 Changes - by daniel0916 - 02-05-2014, 03:00 AM
RE: 1.8 Changes - by FakeTruth - 02-05-2014, 07:03 AM
RE: 1.8 Changes - by daniel0916 - 02-05-2014, 04:05 PM
RE: 1.8 Changes - by FakeTruth - 02-05-2014, 11:07 PM
RE: 1.8 Changes - by xoft - 02-06-2014, 01:30 AM
RE: 1.8 Changes - by daniel0916 - 02-07-2014, 03:20 AM
RE: 1.8 Changes - by daniel0916 - 02-09-2014, 05:42 AM
RE: 1.8 Changes - by xoft - 02-09-2014, 06:55 AM
RE: 1.8 Changes - by tigerw - 02-09-2014, 07:05 AM
RE: 1.8 Changes - by xoft - 02-09-2014, 07:07 AM
RE: 1.8 Changes - by daniel0916 - 02-09-2014, 08:41 PM



Users browsing this thread: 5 Guest(s)