port forwarding not working

[Stoveclock]

is your router, your modem at the same time, or are you running like this modem-router-raspi ?
Then also open up the ports in the modem.
some modems for some odd reason need to be restarted for the changes to take effect, most of the time it will tell you so, sometimes it just doesn't.

My modem is a modem/router combo and it restarts automatically. I have my raspi connected via Ethernet