01-26-2019, 12:58 AM
I like the new string-based format, it is highly extensible, plugins could finally be made to extend the blocks and items easily. And I don't think it's too much slower than current, in the end most of the operations are just number-based (and we're going from two numbers per block to a single number per block); the operations on strings only take place when manipulating something in a way that doesn't require too much performance, such as placing and removing blocks.
If we find that the string manipulation is slow, we could adapt it with additional performance boosters, such as hashing the entire BlockState to improve comparison, etc.
And, on the plus side, having a per-cProtocol map of block types means that we can finally support older protocols properly - the blocks not available in them can get replaced with a placeholder, rather than sent through and crashing the client.
If we find that the string manipulation is slow, we could adapt it with additional performance boosters, such as hashing the entire BlockState to improve comparison, etc.
And, on the plus side, having a per-cProtocol map of block types means that we can finally support older protocols properly - the blocks not available in them can get replaced with a placeholder, rather than sent through and crashing the client.