Pull requests remain open for too long
#10
(03-03-2016, 04:50 AM)NiLSPACE Wrote: @warmist what was bugging you while contributing? That is something we'll have to work on. We're all working on Cuberite, so naturally we have to get along Smile

I'm not saying it was awful. Just the general no-reaction whatsoever interspaced with one comment about one line. You do a rebase (because it's out of date yet again) then another line is not to standard for someone. It could just be me and my lack of concentration/effort but imho it should be more lax. Yes it would have more bugs be less maitainable but we are not building corporate software for the overlords - i get enough of that from my day job and having to adhere to yet another set of arbitrary rules (5 spaces between functions?! really? so that you could never see two functions and never understand any links between?) just saps my willpower to contribute at least at C++ side and seems like every comment is like somebody trying to find some fault so it would not get added in. </rant>

As for "if you don't like it don't contribute" - I understand that might sound very harsh and unfriendly, but what i'm saying is just because i believe that this could be better and Cuberite itself has HUGE potential. I mean you guys have done so much already and I'm very grateful and i'm really hoping this gets picked up by many more contributors (unless my estimates are off and there are no C++ programmers left in this minecraft+(c++)+has_time set).

So my solution (at least for now) is code for myself, in my own fork without any pull-req and style guides, and if anyone (including me) thinks that any of my code has merit i (or anyone else is welcome) could tidy the code up for the main fork. I will still create issues where i find bugs in main code and try to be active in forums and hopefully that is enough.
Reply
Thanks given by:


Messages In This Thread
RE: Pull requests remain open for too long - by warmist - 03-03-2016, 08:20 AM



Users browsing this thread: 2 Guest(s)