07-01-2013, 04:51 AM
Hi, welcome to the community.
It's always good to hear praise, and it's really awesome to be inspiring someone enough to join the team. We're lacking the manpower needed to keep up with the vanilla MC, so every helping hand counts.
As for the contributions, I see you've made a real effort on describing them in the flyspray tracker; I personally would have preferred a patch file. Since FS doesn't seem to accept file attachments at all, the easiest way would be either to post them to this forum, or send them via PM to one of the devs. Currently, that means FakeTruth or myself (I do hope the other contributors won't take offense for me not including them).
Unfortunately I'm already working on FS #297 (player staying on fire) as a part of a bigger rewrite, I'm moving all the damage-handling code from cPawn to cEntity and unifying the fire handling there. I was hoping it would be a fast fix, but it turned out a big one, so it's still gonna take some time. Just as a quick tasting of the new refactoring, I'd like to drop all the cPawn's MetaData, replacing them with cEntity's functions and the network protocol translating functions like IsOnFire() to entity metadata as needed. We've already seen several changes in the protocol that de facto broke these things, so it makes more sense to have them separate from protocol representation.
Feel free to post the other two as patches here, I'd like to review them before merging
Thanks again.
It's always good to hear praise, and it's really awesome to be inspiring someone enough to join the team. We're lacking the manpower needed to keep up with the vanilla MC, so every helping hand counts.
As for the contributions, I see you've made a real effort on describing them in the flyspray tracker; I personally would have preferred a patch file. Since FS doesn't seem to accept file attachments at all, the easiest way would be either to post them to this forum, or send them via PM to one of the devs. Currently, that means FakeTruth or myself (I do hope the other contributors won't take offense for me not including them).
Unfortunately I'm already working on FS #297 (player staying on fire) as a part of a bigger rewrite, I'm moving all the damage-handling code from cPawn to cEntity and unifying the fire handling there. I was hoping it would be a fast fix, but it turned out a big one, so it's still gonna take some time. Just as a quick tasting of the new refactoring, I'd like to drop all the cPawn's MetaData, replacing them with cEntity's functions and the network protocol translating functions like IsOnFire() to entity metadata as needed. We've already seen several changes in the protocol that de facto broke these things, so it makes more sense to have them separate from protocol representation.
Feel free to post the other two as patches here, I'd like to review them before merging
Thanks again.