1.8 Changes

[daniel0916]

First of all AFAIK a long is 4 bytes (=32 bits) and you're shifting it 38 bits. This will most definitely result in overflow of the value.

Which should i use then?

Second -not really a problem- is the way you use LOGWARN. The log function takes a formatted string so you should write LOGWARN("%i", x); instead of the whole std::to_string() stuff.

Okay, thanks.

Last this totally blows my mind:

Code:

long z2 = value << 38 >> 38;

The order in which the shifts occur is not clear at all. And you're shifting it with the same value to both sides which should result in no change? idk.. confusing.

This code is from the pre release protocol site (http://wiki.vg/Pre-release_protocol#Position)

Do you know what you're doing or are you just trying something?

With Protocol yes. But with the new Position data currently no.