Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1074 thank(s) in 852 post(s)
And we have yet another leak. If a plugin says it doesn't want to close the window (OnClosing returns true), but the close event is triggerred by a player disconnecting, the window object will not be freed until the server is stopped. So the Login plugin can actually be used to DoS the server
Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1074 thank(s) in 852 post(s)
Well, I think there's so many DoS-able holes in the server that one like this doesn't hurt, but it's the memory leak that's getting on my nerves.
Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1074 thank(s) in 852 post(s)
Rev 1543 should fix the leak.