Who is Howaner?
#1
I've just noticed this guy in the GitHub network viewer ( https://github.com/mc-server/MCServer/network ); he seems to have made some really good changes in the server, but he doesn't make any PRs. I wish he made his changes on separate branches and into PRs, I'd like to merge quite a few of them, but have issues with some things (such as thread safety in cServer::GetPlayer()).
Reply
Thanks given by:
#2
Howaner is a friend from me. He will fix the bugs in the server. I also started with them. I will ask him when he will make a PR.
Write the Issues and i will send it to him. Smile.
Reply
Thanks given by:
#3
Please ask him to separate each fix onto a branch and make a PR early on. The more he waits, the more difficult it will be to join the sources back. It also opens up the discussion, which is much needed, especially in his case.
Reply
Thanks given by:
#4
I asked him. He will do it and he wants to sign up here.
Reply
Thanks given by:
#5
I have made a Pull Request.
https://github.com/mc-server/MCServer/pull/663

The Changes are now in the Fixes Branch.
Reply
Thanks given by:
#6
Hello, and welcome to the team Smile
Reply
Thanks given by:




Users browsing this thread: 1 Guest(s)