04-26-2015, 08:16 PM
Regarding the code:
I merged cPathFinder and cPath into one class and called it cPath. The changes have been pushed to Github, there's still some polishing to be done but the interface and the code already feel much cleaner. Comments are welcome, especially about the interface.
Regarding code style:
I merged cPathFinder and cPath into one class and called it cPath. The changes have been pushed to Github, there's still some polishing to be done but the interface and the code already feel much cleaner. Comments are welcome, especially about the interface.
Regarding code style:
- Can I make CheckBasicStyle.lua only check a specific file? scanning the whole project is just too slow.
- The constructor line is pretty long, I wanted to spread the parameters over several lines, but I can't seem to satisfy CheckBasicStyle.lua. What is your code convention here? Do you just keep the long line?
- Should I indent after an #ifdef?
- I removed most of the debugging mode bloat, only the really needed parts remain. The flag is stilled called __PATHFIND_DEBUG, better name suggestions are welcome.
- I hope all the code convention issues are fixed, Comments are welcome.