Redstone...
#8
Just some things I noticed

Code:
Redstone.cRedstone::ChangeRedstoneTorch( PacketData->m_PosX, PacketData->m_PosY, PacketData->m_PosZ, false );
Should be written as
Redstone.ChangeRedstoneTorch( PacketData->m_PosX, PacketData->m_PosY, PacketData->m_PosZ, false );
You do this in many places

________________________________

You store a cWorld pointer in the cRedStone class, but still you use cRoot::Get()->GetWorld() to get a world pointer... You can simply use m_World, because that's where you stored it.
Code:
cClientHandle.cpp:
cRedstone Redstone(m_Player->GetWorld());

cRedstone.cpp:
cRedstone::cRedstone( cWorld* a_World )
        :m_World ( a_World ) // This is the same as writing m_World = a_World; but faster
{
}
...
void cRedstone::ChangeRedstoneTorch( int fillx, int filly, int fillz, bool added )
{
...
        cWorld* World = cRoot::Get()->GetWorld();
...
}

___________________________

I just manually edit the makefile with a text editor, and the Visual Studio project is edited through Visual Studio

Alright, carry onTongue
Reply
Thanks given by:


Messages In This Thread
Redstone... - by rs2k - 11-02-2011, 12:22 PM
RE: Redstone... - by FakeTruth - 11-02-2011, 12:48 PM
RE: Redstone... - by rs2k - 11-02-2011, 01:15 PM
RE: Redstone... - by rs2k - 11-04-2011, 03:55 AM
RE: Redstone... - by rs2k - 11-04-2011, 05:26 AM
RE: Redstone... - by FakeTruth - 11-04-2011, 10:22 AM
RE: Redstone... - by rs2k - 11-04-2011, 03:12 PM
RE: Redstone... - by FakeTruth - 11-05-2011, 01:53 AM
RE: Redstone... - by rs2k - 11-06-2011, 04:46 AM
RE: Redstone... - by rs2k - 11-09-2011, 11:35 AM
RE: Redstone... - by NiLSPACE - 11-28-2012, 05:29 AM



Users browsing this thread: 6 Guest(s)