09-05-2019, 01:14 AM
(09-04-2019, 11:29 PM)xoft Wrote: https://github.com/cuberite/cuberite/issues/4375 should be a much better candidate - it's really self-contained, it means writing entirely new code, has almost zero chance of breaking stuff and it's crystal clear we'll be needing it. On the other hand, it will be a long time before it is possible to actually test it out in real world, at first it will only need to be tested using internal tests, since it will be used by the 1.13+ protocols, which will take a lot of time to develop.
Thanks, yes I noticed the 1.13 issue. Hard to miss
I'll look into #4375, but your OTOH brings me to a question... I found only integration tests, are Unit tests a goal/non-goal/did I miss them? Especially since you mention that it may be a long while until the class could actually be integrated, that kinda calls for some unit tests