Getting involved
#7
(09-10-2019, 10:15 PM)xoft Wrote: BUILD_TOOLS=1 to build them
OMG thanks! It's the small things, I tell you...

The lawyer thing, I actually wanted to ask about it here and decided to skip it for now and not bother you Blush .

If it's about having a converter in between, I could flatten the format, eg.:
Code:
[
  {
    "props": {
      "axis": "x"
    },
    "id": 72,
    "name": "minecraft:oak_log"
  },
  {
    "props": {
      "axis": "y"
    },
    "id": 73,
    "name": "minecraft:oak_log"
  },
]

Then the size difference should be minimal once zipped.

I guess we can argue about the future compatibility thing, but I'd say if they stick to JSON, parsing it using JSON will increase the chance that changes are implemented more easily than if you're converting to a completely different representation.

(09-10-2019, 10:15 PM)xoft Wrote: At the very worst, when you open a pull request, mark it as draft, CI will still build it and we'll know it still needs work on your end. That way you'll get it checked, we use Appveyor for VC builds.


I'll do that, thanks!
Reply
Thanks given by:


Messages In This Thread
Getting involved - by e14 - 09-04-2019, 07:58 PM
RE: Getting involved - by xoft - 09-04-2019, 11:29 PM
RE: Getting involved - by e14 - 09-05-2019, 01:14 AM
RE: Getting involved - by xoft - 09-05-2019, 03:22 AM
RE: Getting involved - by e14 - 09-10-2019, 09:36 PM
RE: Getting involved - by xoft - 09-10-2019, 10:15 PM
RE: Getting involved - by e14 - 09-10-2019, 11:30 PM
RE: Getting involved - by xoft - 09-11-2019, 04:23 PM
RE: Getting involved - by e14 - 09-12-2019, 02:43 AM
RE: Getting involved - by xoft - 09-12-2019, 06:48 PM
RE: Getting involved - by e14 - 09-17-2019, 05:39 PM
RE: Getting involved - by xoft - 09-23-2019, 06:58 AM
RE: Getting involved - by e14 - 09-23-2019, 05:10 PM
RE: Getting involved - by xoft - 09-23-2019, 05:24 PM
RE: Getting involved - by Seadragon91 - 09-25-2019, 02:02 AM
RE: Getting involved - by Bond_009 - 09-25-2019, 07:42 AM
RE: Getting involved - by Seadragon91 - 09-26-2019, 01:14 AM



Users browsing this thread: 3 Guest(s)