Sending packets to deallocated cClientHandle

[FakeTruth]

Server can send packets to a cClientHandle that no longer exists, a dangling pointer.

It happens in cChunk::Broadcast, but it crashes somewhere deeper in the stack.



Something to note is that the server was updating .pak files from version 2 to 3. A client disconnected somewhere in the middle of conversion (thought it has a different address than the dangling pointer), and the server crashes after conversion was done.

Simply put, cChunk had a dangling pointer in m_LoadedByClient

[xoft]

You could have captured a crashdump for later analysis. Without it there's not much I can do.

[xoft]

And how did the client disconnect? If it was already downloading terrain, then it shouldn't disconnect (we answer to keepalives) and the client has no GUI for disconnecting at that state, other than closing the client altogether.

[FakeTruth]

And how did the client disconnect? If it was already downloading terrain, then it shouldn't disconnect (we answer to keepalives) and the client has no GUI for disconnecting at that state, other than closing the client altogether.

When the player is already in the game, and moves to somewhere that hasn't been converted yet, the player can simply press escape and disconnect

[xoft]

Right, somehow I thought you were referring to the initial connection phase.

Well, anyway, I'm afraid you're on your own on this one, as I haven't seen such a failure happen yet.

[FakeTruth]

I tried to track down why this happened, but I can't find a reason