Random Chitchat 2012-2016

[Luksor]

Xoft, are you working on 1.4.2 compatibility? I can try to make the server 1.4.2 compatible with current multi-protocol system but I heard you want to change it to something different.

[xoft]

I currently have no time left for MCServer, so I'm not working on anything. If you want to try, go ahead and implement the 1.4.2 in the current multi-protocol support (if you need any changes that would break it, I guess it's okay to do so).
I'd like to review the changes though before they make it to the svn, if it's okay with you

[Luksor]

Okay, I'll post a patch file when I'm done.

[Luksor]

Ok, very basic 1.4.2 support done
Here you go: https://dl.dropbox.com/u/21041937/142.patch

What's broken:
- Server is shown as 1.3 on the list (click refresh, then join to connect)
- Pickups are crashing clients because they are sent differently: http://www.wiki.vg/Slot_Data

[NiLSPACE]

huh you can commit it yourself right? :O

[Luksor]

Yeah, I can but xoft wanted to see the code first, so I'm waiting for his decision.

[xoft]

I think you should have based the cProtocol142 class on the cProtocol132 class - that way you wouldn't have needed to override so many functions. Especially the encryption and decryption wouldn't be duplicated across two sourcefiles.

---

I know it's easy to copy-paste an entire file and then tweak a few details, but it's a nightmare to maintain later on.

[Luksor]

That's true. I'm gonna make it the right way now.

[xoft]

Alright, I'm gonna have a dinner, so I'll do a bit of coding alongside it I'll fix the protocol version reported, so that you can connect without clicking Refresh

---

Mwahahaha

[Luksor]

Haha, good job!

I've removed all unnecessary functions from the new protocol file but now it seems that server uses both 1.3.2 and 1.4.2 for one client.
https://dl.dropbox.com/u/21041937/142-2.patch

[15a8|20:48:34] Created cProtocol132 at 0811A888
[15a8|20:48:34] Created cProtocol142 at 0811A888