There were reports of this error even before the TickGrass() existed, so it can't be the sole cause. Still, the function should be mostly inert - there shouldn't be too many spots where the grass could grow in a freshly generated world.
Luksor, could you please test Rev 566, but with the old packetqueue limit (changed in Rev 565), and post a log?
Ah, finally I found out why I was unable to replicate the issue - I had my viewdistance set to 5 instead of the default 9. Setting it to the default made the issue immediately manifest itself.
So I found and fixed one error in TickGrass(), but there's still something fishy going on, there are still too many blocks turning into grass, so there must be another bug somewhere in there.
Great, that was hilarious!
One part of TickGrass tried to turn all dirt blocks into grass. The other part tried to turn all grass blocks back to dirt. So the two were fighting and the protocol sufferred.
The main problem, the error in TickGrass, has been fixed in Rev 567, but for saved levels where that fight took place, the post-game still plays out - those underground grass blocks still need to be turned to dirt.
If you delete your level, you should probably be okay from those "too many packets" errors. If you don't want to delete your level, you'll need to log in a few times, it will slowly repair itself. Or you can wait for a proper protocol fix (not sure if it's gonna happen, though).
Or you can set your default viewdistance (in settings.ini) lower for a moment, that way you can login and walk around.
Luksor, could you please test Rev 566, but with the old packetqueue limit (changed in Rev 565), and post a log?
Ah, finally I found out why I was unable to replicate the issue - I had my viewdistance set to 5 instead of the default 9. Setting it to the default made the issue immediately manifest itself.
So I found and fixed one error in TickGrass(), but there's still something fishy going on, there are still too many blocks turning into grass, so there must be another bug somewhere in there.
Great, that was hilarious!
One part of TickGrass tried to turn all dirt blocks into grass. The other part tried to turn all grass blocks back to dirt. So the two were fighting and the protocol sufferred.
The main problem, the error in TickGrass, has been fixed in Rev 567, but for saved levels where that fight took place, the post-game still plays out - those underground grass blocks still need to be turned to dirt.
If you delete your level, you should probably be okay from those "too many packets" errors. If you don't want to delete your level, you'll need to log in a few times, it will slowly repair itself. Or you can wait for a proper protocol fix (not sure if it's gonna happen, though).
Or you can set your default viewdistance (in settings.ini) lower for a moment, that way you can login and walk around.