09-22-2012, 06:57 AM
I'd say the refactoring is more or less complete, as of rev 869. There are still some minor issues, but I think those will be ironed out as needed.
I have found only one issue so far with the new system - in a chest window, when the hotbar is not empty and the player shift-clicks an item in the main inventory, the client moves the item to the chest, but MCS then moves the item into the hotbar. Shift-clicking a hotbar item moves it into the chest. Also, when the hotbar is full, the item is moved to chest. Just one cornercase, probably not too usual.
This is deliberate, because on the other hand if you shift-craft something with an empty hotbar, you want the newly crafted items to go to the hotbar instead of the inventory, so hotbar is given top priority in the shift-click distribution algorithm.
I have found only one issue so far with the new system - in a chest window, when the hotbar is not empty and the player shift-clicks an item in the main inventory, the client moves the item to the chest, but MCS then moves the item into the hotbar. Shift-clicking a hotbar item moves it into the chest. Also, when the hotbar is full, the item is moved to chest. Just one cornercase, probably not too usual.
This is deliberate, because on the other hand if you shift-craft something with an empty hotbar, you want the newly crafted items to go to the hotbar instead of the inventory, so hotbar is given top priority in the shift-click distribution algorithm.