UUID Changes

daniel0916 · (This post was last modified: 04-16-2014, 04:11 AM by daniel0916.)

Cracked login is working in 1.7.9.

daniel0916 · 04-19-2014, 11:30 PM

I added the GetUUID Method.
https://github.com/daniel0916/MCServer/c...4fec44607c

Should i move it in a other class? or is it so good?

bearbin · 04-19-2014, 11:59 PM

Is cPlayer not for an individual player, so having it on every player is strange?

daniel0916 · (This post was last modified: 04-20-2014, 12:12 AM by daniel0916.)

Oh i forgot this.
Okay maybe cServer::GetPlayerUUID or what do you think?

xoft · 04-20-2014, 12:51 AM

Your change is silly, because it effectively duplicates most of the code in cAuthenticator.

Such a function would make sense to be static, so that it's not bound to a specific cPlayer instance, but it is still in the cPlayer class "namespace".

daniel0916 · (This post was last modified: 04-20-2014, 01:02 AM by daniel0916.)

Yes, the code is from cAuthenticator but with some changes for a POST request to the mojang api.

The GetUUID method is already static. Or what do you mean?

bearbin · 04-20-2014, 01:35 AM

Code should not be in two places at once.

xoft · 04-20-2014, 02:26 AM

Didn't see the static declaration.

I'm not sure if this function is a good idea. It it blocking, so it can pause the calling thread for considerable amounts of time. So it cannot be used from plugins at all, and only very few MCS threads can afford the pause.

daniel0916 · 04-20-2014, 02:41 AM

How can i fix this?
The function is for plugins to get the UUID of a playername. So the plugin can convert her ban lists etc. and add the UUID's.

xoft · 04-20-2014, 09:45 PM

I'd say the plugins that want to do this should implement the HTTP request / response handling by themselves; we should provide them with asynchronous (callback-based) sockets, SSL layer and perhaps HTTP client parsing.