Fishing Speed Too Slow

[the1robert]

Is there a way to change the fishing speed ? 

According to https://minecraft.gamepedia.com/Fishing the wait should be between 5 and 45 seconds.

However in testing build 1b41342feedc04aed0f702b376e764410d5ebb6f I had the following results:

1. 55 seconds
2. 1 minute 23 seconds
3. 2 minutes
4. 1 minute 16 seconds
5. 1 minute 5 seconds
6. 1 minute 50 seconds

This is with a standard fishing rod during a clear day and no enchantments.

Thanks,

Robert

[NiLSPACE]

That's quite easy to fix. In this line

(Random.RandInt(100, 900) - static_cast<int>(a_Player->GetEquippedItem().m_Enchantments.GetLevel(cEnchantments::enchLure) * 100))

should be changed to produce less ticks.

[ShadowCone]

Why are these static numbers in source code :eyes:

[the1robert]

If I'm reading it right, that code would seem to be correct... 100 ticks / 20 tps = 5 seconds and 900 /20 tps = 45 seconds. 

The enchantment even takes off the right amount of time. 100 ticks or 5 sec each level. 

The tps of my server is always 19.99 something or 20 even.  Is there any other code that might be affecting the fishing speed?

I just tested it again on a clear day with the sun directly overhead and I still got up to 1 minute 50 seconds (Which is more than double what it should be).

That's quite easy to fix. In this line

(Random.RandInt(100, 900) - static_cast<int>(a_Player->GetEquippedItem().m_Enchantments.GetLevel(cEnchantments::enchLure) * 100))

should be changed to produce less ticks.

[peterbell10]

I think I've figured it out: https://github.com/cuberite/cuberite/pull/4217
The timer just wasn't being updated every tick so it was taking longer than the timer value would suggest.

[the1robert]

I made the change in your commit, rebuilt it and tested on a clear day with the sun directly over head using a regular pole no enchantments (same as last time)

This time I got :

1. 21 Seconds
2. 6 Seconds
3. 19 Seconds
4. 37 Seconds
5. 36 Seconds
6. 12 Seconds

Looks good! All of them are within the range expected.  And it makes fishing a much more interesting proposition.

Thank You!

I think I've figured it out: https://github.com/cuberite/cuberite/pull/4217
The timer just wasn't being updated every tick so it was taking longer than the timer value would suggest.