The following warnings occurred:
Warning [2] Trying to access array offset on null - Line: 198 - File: inc/plugins/google_seo.php PHP 8.3.36 (Linux)
File Line Function
/inc/class_error.php 157 errorHandler->error
/inc/plugins/google_seo.php 198 errorHandler->error_callback
/inc/plugins/google_seo/redirect.php 131 google_seo_tid
/inc/class_plugins.php 142 google_seo_redirect_hook
/global.php 100 pluginSystem->run_hooks
/showthread.php 28 require_once
Warning [2] Undefined property: DB_MySQLi::$google_seo_query_limit - Line: 232 - File: inc/plugins/google_seo.php PHP 8.3.36 (Linux)
File Line Function
/inc/class_error.php 157 errorHandler->error
/inc/plugins/google_seo.php 232 errorHandler->error_callback
/inc/plugins/google_seo/redirect.php 131 google_seo_tid
/inc/class_plugins.php 142 google_seo_redirect_hook
/global.php 100 pluginSystem->run_hooks
/showthread.php 28 require_once
Warning [2] Decrement on type null has no effect, this will change in the next major version of PHP - Line: 232 - File: inc/plugins/google_seo.php PHP 8.3.36 (Linux)
File Line Function
/inc/class_error.php 157 errorHandler->error
/inc/plugins/google_seo.php 232 errorHandler->error_callback
/inc/plugins/google_seo/redirect.php 131 google_seo_tid
/inc/class_plugins.php 142 google_seo_redirect_hook
/global.php 100 pluginSystem->run_hooks
/showthread.php 28 require_once




Relax merge requirements
#1
There was a recent change to apparently make all PRs unmergeable unless someone reviews, even to admins.

I commend the good software engineering principles, but because everyone is volunteering their time, this isn't working. It's also important to remember we are writing a Minecraft server, not a control system for a reactor. Getting stuff merged is a bit of an uphill battle at the moment, and excessive nitpicking is sometimes quite trying.

The current settings are needlessly restrictive. Can we please change them back to allow discretion to commit/merge?
Reply
Thanks given by:
#2
In my opinion if the changes are small I'm fine with letting the changes go through without a review as we're lacking developers to review changes. I do think everything has to be added using a pull request though. That way we can easily trace back changes later on.
Reply
Thanks given by:




Users browsing this thread: 1 Guest(s)