Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1074 thank(s) in 852 post(s)
We've got some really bad threading issues with entity management in the world, especially with players. There's no locking around players disconnecting from the world and being removed etc. This will need an in-depth analysis and proper fixing.
Posts: 681
Threads: 26
Joined: May 2014
Thanks: 112
Given 48 thank(s) in 37 post(s)
What about making a freeze? This should give us time for fixing errors.
Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1074 thank(s) in 852 post(s)
Making a freeze? What do you mean?
Posts: 681
Threads: 26
Joined: May 2014
Thanks: 112
Given 48 thank(s) in 37 post(s)
We stop the further development of MCServer and reject every new feature for a while. This is a common method in software development. After making this freeze (Mostly a sticky post in the forum) we are able to make deeeep fixes in the code without worrying about new stuff coming in.
Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1074 thank(s) in 852 post(s)
Oh, a feature freeze. I don't think that'll help much. There aren't many people who could actually touch the very internals of MCS that need to be fixed. And there's not much that new features could collide with anyway, so if the other contributors continue adding "small" features such as new generators, gameplay elements, even the simulators, it still won't conflict. It's not like we need to throw out half the codebase and write it anew, it's specific areas that need to be revised, the development could continue around it.
Posts: 4,628
Threads: 115
Joined: Dec 2011
Thanks: 693
Given 494 thank(s) in 423 post(s)
I tried fixing a problem in the Core's webchat where you can't send certain characters, but it seems like the problem isn't in the Core. When there is an equal symbol in the chat message the whole post param is skipped. (Request.PostParams["ChatMessage"] == nil)
Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1074 thank(s) in 852 post(s)
Could be that there's a problem in the HTMLFormParser.