Random Chitchat 2012-2016
Seems good.
Thanks given by:
Not a good idea.

It will be difficult to use properly - it needs a cEntity parameter, which is hard to get in Lua. Plugin writers must not keep a cEntity object in a variable because it could get destroyed in the meantime.

It'd be much better to make a cWorld::AttachEntity(int a_EntityID, int a_VehicleEntityID) so that you can use entity IDs for attaching.
Thanks given by:
If I read this correctly, Notch added redstone in a single week. We suck.
http://www.minecraftwiki.net/wiki/Seecret_Updates
Thanks given by:
Redstone was a lot simpler thenTongue But that's quite a short time for such a major feature!
Thanks given by:
I created 2 new functions that replace specific block types/metas to the given ones in a blockarea.
I have no idea how to create a branch or a pull request, so I created a patch.


Attached Files
.patch   Replace.patch (Size: 1.99 KB / Downloads: 200)
Thanks given by:
1) The header has bad declaration, ReplaceBlock has XXXMeta parameters
2) The parameter names are not clear enough, it takes a while to decipher which is the old meta / type and which is the new one. Call them From / To.
3) The functions are needlessly complicated and thus ineffective. Since they operate on the entire array of blocktypes / blockmetas, they could use a single for-loop going through all m_BlockMetas[] / m_BlockTypes[] by an increasing index.
4) The functions don't check the contained datatypes, what if there are no blocktypes read into the BlockArea?

To create a branch in Git, execute this command anywhere inside the repository:
git checkout -b NameOfBranch

Then you can normally commit and push (use git gui to push to server to avoid the need to specify extra parameters). Once you're happy with the branch's contents, you use the GitHub web to create a pull request - it will be there automatically once you create and push a branch.

You can even switch back and forth between the branch and the master in your working copy, simply by
git checkout master
git checkout NameOfBranch

Oh, by the way, don't let the above 4 points discourage you from coding further. I mean, the code is good, I'd have accepted it from you a few months ago, but I now consider you more advanced so I give you a more strict treatment Smile
Thanks given by:
Authentication doesn't seem to work (again?).
Thanks given by:
Sad That's bad.
Thanks given by:
It seems like we also finaly get a sprint button in 1.7: https://twitter.com/dinnerbone/status/36...4273035264
Thanks given by:
That's one ugly screen, hope they fix it before a releaseTongue
I hope the old doublepress-forward-to-run will still work, I will need some time to get used to new controls.
And what is that cinematic camera?
Thanks given by:




Users browsing this thread: 211 Guest(s)