Ah, that's just a "logging malfunction" - the log message is produced in the constructor. You can safely ignore that and I'll fix that somehow, later.
I like the patch now, just cosmetics remain: the #include-s for crypto can be left out. And the "login packet" that you're getting is probably just a leftover from some other packet (could be 0xfe - server list ping); in any case the constant for it needn't be defined ('cause you're not sending it).
Oh, and in cProtocolRecognizer, I've introduced names for the "magic number constants" - protocol versions. If you used that instead of "47", that'd be nice.
Now that you have all my criticism, you can commit the changes![Smile Smile](https://forum.cuberite.org/images/smilies/smile.png)
Dinner's over, that concludes my today's involvement with MCS
I like the patch now, just cosmetics remain: the #include-s for crypto can be left out. And the "login packet" that you're getting is probably just a leftover from some other packet (could be 0xfe - server list ping); in any case the constant for it needn't be defined ('cause you're not sending it).
Oh, and in cProtocolRecognizer, I've introduced names for the "magic number constants" - protocol versions. If you used that instead of "47", that'd be nice.
Now that you have all my criticism, you can commit the changes
![Smile Smile](https://forum.cuberite.org/images/smilies/smile.png)
Dinner's over, that concludes my today's involvement with MCS