Posts: 6,486
Threads: 176
Joined: Jan 2012
Thanks: 40
Given 157 thank(s) in 838 post(s)
Funny thing happened. As you might know, the Windows builds run on my home computer. Now I was working on the GalExport plugin and at the same time a build was underway. But because my debugging session had the default port already open, the build-executable wouldn't start and so it failed to generate some of the runtime files - API description, .luacheckrc etc. All this happened silently and I wouldn't have noticed, if I didn't attempt to add LuaCheck to GalExport in that very moment and the CI on GalExport failed, because the API zip file downloaded from the Buildserver was empty.
Posts: 4,621
Threads: 113
Joined: Dec 2011
Thanks: 51
Given 58 thank(s) in 410 post(s)
The server crashing on cEntity:IsA(nil) and GetChar() are bugs, but cWorld:SetBlock asserting is right because the block isn't valid and the last argument you provided is a number while it is an optional bool.
Posts: 681
Threads: 26
Joined: May 2014
Thanks: 0
Given 8 thank(s) in 37 post(s)
Just for the record: I just closed every PR up until and including October 2016 as they all seem to be abbandoned
Posts: 681
Threads: 26
Joined: May 2014
Thanks: 0
Given 8 thank(s) in 37 post(s)
I'd like to propose a more strict handling of open pull requests: When a PR is opened it will be getting closed after one month if it didn't got merged until then. This keeps out old and untouched PRs and might even speed up the development process. We could add a notice to the PR template on github. Thoughts?
Posts: 372
Threads: 29
Joined: Mar 2011
Thanks: 1
Given 5 thank(s) in 17 post(s)
What would happen if somebody made a pr thats based on a older one ?
The older one passed the month, so the one thats based on it won't even work anymore.
Or if its a pr that needs a ton of discussing about changes ?
I seen quite some that have a huge discussion between multiple, so at least a month without discussing/activity instead a month after opening.