11-12-2012, 08:39 PM
I think the patch is alright; I only have an issue with the condition - could you put some extra parenthesis in there, so that it's immediately clear what compares to what?
I really hate stuff like "if (A || B && C)" - does it first do the || or the &&? And why should I have to think about it? "if ((A || B) && C)" is so much clearer.
Also, a comment about why the condition is so complicated would be welcome.
I really hate stuff like "if (A || B && C)" - does it first do the || or the &&? And why should I have to think about it? "if ((A || B) && C)" is so much clearer.
Also, a comment about why the condition is so complicated would be welcome.