There's difference for negative numbers - modf rounds towards zero, while floor rounds towards negative infinity (which is what you need for chunk coords)
For example, block coords {-8, 10, -8} are in chunk [-1, -1], but mod would've calculated chunk [0, 0].
Gentlemen, we are in for a sweet addition
Unfortunately in this screenshot the lighting is still wrong, I suppose the client needs to be told to use a different lighting engine for different dimensions. This is what Nether terrain would look if you took it to overworld:
I have to say I'm amazed at how epic the nether generator is. Now it needs just a few tweaks at the floor and ceiling, some embellishments by soulsand / gravel, a fire here and there, with a few lava springs, and hey, we have the Nether
For example, block coords {-8, 10, -8} are in chunk [-1, -1], but mod would've calculated chunk [0, 0].
Gentlemen, we are in for a sweet addition
Unfortunately in this screenshot the lighting is still wrong, I suppose the client needs to be told to use a different lighting engine for different dimensions. This is what Nether terrain would look if you took it to overworld:
I have to say I'm amazed at how epic the nether generator is. Now it needs just a few tweaks at the floor and ceiling, some embellishments by soulsand / gravel, a fire here and there, with a few lava springs, and hey, we have the Nether