Posts: 1,469
Threads: 57
Joined: Jul 2012
Thanks: 66
Given 127 thank(s) in 108 post(s)
I think that it should be seperate as it really is a seperate project, as well as the utility of the second issue system and PRs.
However if it's so inconvenient you can move it back....
Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1075 thank(s) in 852 post(s)
Or we could delete it from the main repo. The point is that there are two places where the code resides and the history diverges for them quite often.
Maybe it's even possible to configure git in such a way that the Core repo can be cloned locally into the correct folder inside the main repo and still be ignored by the main repo and committed to in the Core repo. This might just work - add the Plugins folder to .gitignore and clone Core there locally. This will enable me to make changes to the Core while having the newest server around it.
If this works, we can then split off all (or most) of the plugins.
Posts: 1,469
Threads: 57
Joined: Jul 2012
Thanks: 66
Given 127 thank(s) in 108 post(s)
Yeah, and the proper way to do that is git submodules - it just makes it a bit more of a pain to pull down - git pull -r instead of git pull.
Posts: 1,469
Threads: 57
Joined: Jul 2012
Thanks: 66
Given 127 thank(s) in 108 post(s)
The only problem is that you would have to manually clone down the plugins when you wanted to run MCServer.
Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1075 thank(s) in 852 post(s)
There's a script for that in the repo root now.
Posts: 1,469
Threads: 57
Joined: Jul 2012
Thanks: 66
Given 127 thank(s) in 108 post(s)
It does seem not the most user friendly method - it could be better if it was inside the makefile.
Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1075 thank(s) in 852 post(s)
Can't do, because the script must be run only once, while the makefile will generally be run multiple times. If you can think of a way, feel free to do it. Also, the script is currently windows-only.
Posts: 1,469
Threads: 57
Joined: Jul 2012
Thanks: 66
Given 127 thank(s) in 108 post(s)
What about when the plugins update?