[FIXED] Saving/Loading terrain bug

[ThuGie]

xoft,

The bug is simply not yet fixed.
I tried a version yesterday and i noticed it always generating but not making any files..
Ran it for half a hour.

Today i noticed the change list so i tried again still the same thing happens so its clearly not saved.
Try a new map btw. as i was trying to generate a new map

[xoft]

Fixed in rev 276

[ThuGie]

Just updated seems to not be fixed yet,
But will let it run for a while..

Edit:After a while it stops loading doesn't create any files.
But as soon as i login it generates a few more files and does save it.

Edit2:
Well.. it seems to work fine havent tried to relogin but got something weird..
When i run into a new area and destroy something the item apears directly yay!.
But when i try to get it as soon as i'm near it my client freezes for a few seconds.. might be on my side though..

[xoft]

Currently the biggest problem is that chunk generation asks too much about its neighbors. Each such query puts the (yet unloaded and ungenerated) chunk in the load queue, where the load thread picks it up just to find that it isn't available for loading, and places it into the generation queue. So the load thread is actually using more CPU than the generation thread, and it's wasting its time doing the unneeded work over and over again.

[ThuGie]

I see i just updated again,
The listing of the chunks seem more clear now a nice countdown.
After a while it gets a bit random again though :p.
I guess those are the surrounding chunks.
But sometimes i get "Cannot save chunk [?, ?]"

the map finally does get saved though but i guess not those chunks i assume its still generating it or something ?

[xoft]

Random?
At server start, the spawn area (20 x 20 chunks around world spawn) is generated. Then when a player connects, chunks are generated in squares around the player beginning with the smallest out to the furthest. So the chunks generated should not be that much random - mostly lines of chunks with one coord right next to the other.

The "Cannot save" message is interesting though. Any chance you can work with a debugger to find out what's causing this?

[ThuGie]

Random?
At server start, the spawn area (20 x 20 chunks around world spawn) is generated. Then when a player connects, chunks are generated in squares around the player beginning with the smallest out to the furthest. So the chunks generated should not be that much random - mostly lines of chunks with one coord right next to the other.

The "Cannot save" message is interesting though. Any chance you can work with a debugger to find out what's causing this?

Hey,

I haven't debugged much with c++ if you give me basic details of what i should do i can run it on this pc and see what pops up.
I could just do start in debug or what it was called :p. - btw i will have to run it on a different system,
As i normaly run it on my "home server/pc".
well first i get it like this
[20,20]
[20,19]
....
[19,20]
[19,19]
.. then when i guess when its finished i dont watch 24/7 :p
[15,12]
[12,19]
etc


[edit-1]
I also seem to get it on this machine.

Code:

[21:57:24] Generating chunk [11, -27]
[21:57:24] Cannot save chunk [11, -28]
[21:57:26] Generating chunk [11, -26]
[21:57:30] Generating chunk [11, -25]
[21:57:32] Generating chunk [11, -24]
[21:57:34] Generating chunk [11, -23]
[21:57:36] Generating chunk [11, -22]
[21:57:38] Generating chunk [11, -21]
[21:57:40] Generating chunk [11, -20]
[21:57:40] Cannot save chunk [11, -21]
[21:57:42] Generating chunk [11, -19]
[21:57:44] Generating chunk [11, -18]
[21:57:47] Generating chunk [11, -17]
[21:57:49] Generating chunk [11, -16]
[21:57:52] Generating chunk [11, -15]
[21:57:52] Cannot save chunk [11, -16]
[21:57:54] Generating chunk [11, -14]
[21:57:57] Generating chunk [11, -13]
[21:57:59] Generating chunk [11, -12]
[21:58:02] Generating chunk [11, -11]
[21:58:02] Cannot save chunk [11, -12]

[xoft]

Unfortunately debugging is the most difficult part of programming so it's very seldom a "run something and see its output", especially in this case.
I'll try adding logging to each code path that would fail a chunk save, that should at least give me some info on what's happening.

[xoft]

Try rev 282 please.

[Boo]

Compiling please on windows I can`t Compile^(