Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1074 thank(s) in 852 post(s)
Nice, I will integrate it.
Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1074 thank(s) in 852 post(s)
I committed the patch (rev 858), but I changed the coords handling - all the specs say that the sound coords are in block coords * 8, so I made all parameters use this "format". Hopefully I didn't break anything - I didn't test the changes other than compiling them.
Also, if the sounds' names are static, consider making the cBlock::GetSoundName() functions' return values const char * instead of an AString, for performance reasons (not creating and copying an object for each step taken).
Posts: 34
Threads: 2
Joined: Mar 2012
Thanks: 1
Given 3 thank(s) in 3 post(s)
OK, apparently they are using that weird multiplication to improve resolution for entities.
I don't know, but maybe it would be better to use double instead of int as coords parameters? Vanilla server has it done that way.
And right, I will change that AString to const char *.
Posts: 6,485
Threads: 176
Joined: Jan 2012
Thanks: 131
Given 1074 thank(s) in 852 post(s)
I think the client actually doesn't permit the player to put those blocks into the helmet slot, without even asking the server. So you'd need a different way than directly placing blocks in the inventory window. Probably with a command, and that should be completely doable (though most likely impractical)