03-25-2013, 02:13 AM
Nice changes. I have just two stylistic remarks:
1, You're double-implementing stuff - the Rank command is implemented once for the Console version and once for the In-game version of the command, although they are essentially the same. The usual approach is to extract the common code into a separate function and have both Console and In-game version call that common function. (Imagine a bug was found in your function, you'll have to remember to fix it in two separate places now)
2, Keep those empty lines between functions, they're there for a reason - when quick-flicking through the code, they make it extra-obvious where functions begin and end.
Good job, I hope we'll get more of your changes
1, You're double-implementing stuff - the Rank command is implemented once for the Console version and once for the In-game version of the command, although they are essentially the same. The usual approach is to extract the common code into a separate function and have both Console and In-game version call that common function. (Imagine a bug was found in your function, you'll have to remember to fix it in two separate places now)
2, Keep those empty lines between functions, they're there for a reason - when quick-flicking through the code, they make it extra-obvious where functions begin and end.
Good job, I hope we'll get more of your changes