06-23-2013, 09:53 PM
I think the plugins should still be allowed to change the weather, even in non-Overworld dimensions. Your patch would disable that. You should modify the TickWeather() function instead.
Also, I prefer if the conditions are not so deeply nested, and rather they bail out quickly. Compare:
and
Also, I prefer if the conditions are not so deeply nested, and rather they bail out quickly. Compare:
if (Condition) { // tons // of // code // to // do }
and
if (!Condition) { return; } // tons // of // code // to // do